Fixing serialisation warning on clientSideRequestDiagnostics#23086
Conversation
simplynaveen20
requested review from
FabianMeiswinkel,
aayush3011,
kirankumarkolli,
kushagraThapar,
mbhaskar,
milismsft,
moderakh and
xinlian12
as code owners
ghost
added
the
There was a problem hiding this comment.
LGTM. we should use a different ObjectMapper than then one with AfterBurner which is used for data payload serialization for diagnostics serialization. Please check if we are using the same ObjectMapper or different.
see this PR for more context:
https://github.com/Azure/azure-sdk-for-java/pull/20114/files
also if possible for internal types and diagnostics we should rely on customer serializer rather than the ObjectMapper auto discovery of the class structure. see this as example:
https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/routing/PartitionKeyInternal.java#L35-L36
simplynaveen20
changed the title
kushagraThapar
left a comment
kushagraThapar
left a comment
There was a problem hiding this comment.
As discussed, this change will not fix the issue.
…ew mapper for tracer/feedDiagnostics/cosmospageflux
simplynaveen20
changed the title
3 participants
Issue -
After burner will throw waring which serialization of package private fields
In ClientSideStatistics class we had some fields which is getting serialized as package private.
Also SystemInfomation was not visible to jackson.
Note: This is only repro on jar which is published to central repo and not the local jar. Will test it on Azure repo before publishing it to maven.
closes #22974